FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/Makefile @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 90d7c360a614 |
children |
line wrap: on
line source
CC= gcc CFLAGS= -O2 PROGS= fcup-at fcup-settime fcup-smdump fcup-smsend fcup-smsendmult \ fcup-smsendpdu fcup-smwrite INSTALL_PREFIX= /opt/freecalypso INSTBIN=${INSTALL_PREFIX}/bin LIBCODING= ../libcoding/libcoding.a ATCMD_OBJS= atcmd.o atinterf.o SETTIME_OBJS= atinterf.o settime.o SMDUMP_OBJS= atinterf.o resp_parse.o smdump.o ${LIBCODING} SMSEND_OBJS= atinterf.o resp_parse.o smsend_cmgw.o smsend_concat.o \ smsend_main.o smsend_pdugen.o smsend_pduout.o smsend_text.o \ ${LIBCODING} SMSENDM_OBJS= atinterf.o resp_parse.o smsend_cmgw.o smsend_multmain.o \ smsend_pdugen.o smsend_pduout.o smsend_text.o ${LIBCODING} SMSENDP_OBJS= atinterf.o resp_parse.o smsend_cmgw.o smsend_pduin.o \ smsend_pduout.o ${LIBCODING} SMWRITE_OBJS= atinterf.o smwrite.o ${LIBCODING} all: ${PROGS} fcup-at: ${ATCMD_OBJS} ${CC} ${CFLAGS} -o $@ ${ATCMD_OBJS} fcup-settime: ${SETTIME_OBJS} ${CC} ${CFLAGS} -o $@ ${SETTIME_OBJS} fcup-smdump: ${SMDUMP_OBJS} ${CC} ${CFLAGS} -o $@ ${SMDUMP_OBJS} fcup-smsend: ${SMSEND_OBJS} ${CC} ${CFLAGS} -o $@ ${SMSEND_OBJS} fcup-smsendmult: ${SMSENDM_OBJS} ${CC} ${CFLAGS} -o $@ ${SMSENDM_OBJS} fcup-smsendpdu: ${SMSENDP_OBJS} ${CC} ${CFLAGS} -o $@ ${SMSENDP_OBJS} fcup-smwrite: ${SMWRITE_OBJS} ${CC} ${CFLAGS} -o $@ ${SMWRITE_OBJS} install: ${PROGS} mkdir -p ${INSTBIN} install -c ${PROGS} ${INSTBIN} clean: rm -f *.o *.out *errs ${PROGS}