FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/resp_parse.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 02d6c8469535 |
children |
line wrap: on
line source
/* * Parsing of structured responses to AT commands */ #include <ctype.h> #include <stdio.h> #include <stdlib.h> #include "resp_parse.h" parse_structured_response(start, fields, max_fields) char *start; struct resp_field *fields; int max_fields; { char *cp; int fieldcnt; cp = start; for (fieldcnt = 0; fieldcnt < max_fields; fieldcnt++) { if (*cp == '\0') break; if (isdigit(*cp)) { fields[fieldcnt].type = RESP_FIELD_NUMBER; fields[fieldcnt].num = strtoul(cp, 0, 10); while (isdigit(*cp)) cp++; } else if (*cp == '"') { cp++; fields[fieldcnt].type = RESP_FIELD_STRING; fields[fieldcnt].str = cp; while (*cp && *cp != '"') cp++; if (*cp != '"') return(-1); *cp++ = '\0'; } else if (*cp == ',') fields[fieldcnt].type = RESP_FIELD_EMPTY; else return(-1); if (*cp == ',') cp++; else if (*cp) return(-1); } return fieldcnt; }