FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_cmgw.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | dc2fd8e6f42c |
children |
line wrap: on
line source
/* * The handling of +CMGW responses and send-after-write for fcup-smsend * family is implemented here. */ #include <sys/types.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <strings.h> #include "../../rvinterf/include/exitcodes.h" #include "resp_parse.h" extern char at_response[]; extern int sms_write_mode; struct saw_rec { unsigned msgid; struct saw_rec *next; }; struct saw_rec *sendafterwr_head, **sendafterwr_tail = &sendafterwr_head; add_sendafterwr_record(msgid) unsigned msgid; { struct saw_rec *rec; rec = malloc(sizeof(struct saw_rec)); if (!rec) { perror("malloc for send-after-write record"); exit(ERROR_UNIX); } rec->msgid = msgid; rec->next = 0; *sendafterwr_tail = rec; sendafterwr_tail = &rec->next; } cmgw_callback() { struct resp_field fields[1]; int cc; /* skip empty lines */ if (!at_response[1]) return; /* if not empty, it MUST be +CMGW */ if (strncmp(at_response+1, "+CMGW: ", 7)) { fprintf(stderr, "error: response from target is not +CMGW\n"); exit(ERROR_TARGET); } if (sms_write_mode == 2) { puts(at_response+1); return; } if (parse_structured_response(at_response+8, fields, 1) != 1) { malformed: fprintf(stderr, "error: malformed +CMGW response\n"); exit(ERROR_TARGET); } if (fields[0].type != RESP_FIELD_NUMBER) goto malformed; add_sendafterwr_record(fields[0].num); } sendafterwr_process() { struct saw_rec *rec; char cmss_cmd[32]; if (!sendafterwr_head) { fprintf(stderr, "error: no +CMGW response received from target\n"); exit(ERROR_TARGET); } if (sendafterwr_head->next) atinterf_exec_cmd_needok("AT+CMMS=1", (char *) 0, (void *) 0); for (rec = sendafterwr_head; rec; rec = rec->next) { sprintf(cmss_cmd, "AT+CMSS=%u", rec->msgid); atinterf_exec_cmd_needok(cmss_cmd, (char *) 0, (void *) 0); } if (sendafterwr_head->next) atinterf_exec_cmd_needok("AT+CMMS=0", (char *) 0, (void *) 0); }