FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_pdugen.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | a38805b5b6d4 |
children |
line wrap: on
line source
/* * This module implements the encoding part of SMS sending/writing in PDU mode. */ #include <sys/types.h> send_in_pdu_mode(da, textsrc, textlen, udh, udhl) u_char *da, *textsrc, *udh; unsigned textlen, udhl; { u_char pdu[158]; unsigned pdulen; char pduhex[317]; pdu[0] = 0; pdulen = make_sms_submit_pdu(da, 0, 0, textsrc, textlen, udh, udhl, pdu + 1); make_hex_string(pdu, pdulen + 1, pduhex); send_pdu_out(pduhex, pdulen); } send_pdu_ucs2(da, textsrc, textlen, udh, udhl) u_char *da, *udh; u_short *textsrc; unsigned textlen, udhl; { u_char ucs2_be[140], pdu[158]; unsigned pdulen; char pduhex[317]; ucs2_out_bigend(textsrc, ucs2_be, textlen); pdu[0] = 0; pdulen = make_sms_submit_pdu_8bit(da, 0, 0x08, ucs2_be, textlen * 2, udh, udhl, pdu + 1); make_hex_string(pdu, pdulen + 1, pduhex); send_pdu_out(pduhex, pdulen); }