FreeCalypso > hg > freecalypso-tools
view uptools/atcmd/smsend_pduout.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | dc2fd8e6f42c |
children |
line wrap: on
line source
/* * This module implements the output part of SMS sending/writing in PDU mode. */ #include <stdio.h> extern void cmgw_callback(); extern int sms_write_mode; prep_for_pdu_mode() { atinterf_exec_cmd_needok("AT+CMGF=0", (char *) 0, (void *) 0); } send_pdu_out(pduhex, pdulen) char *pduhex; unsigned pdulen; { char *cmdname; void (*callback)(); char send_cmd[32]; if (sms_write_mode) { cmdname = "CMGW"; callback = cmgw_callback; } else { cmdname = "CMGS"; callback = 0; } sprintf(send_cmd, "AT+%s=%u", cmdname, pdulen); atinterf_exec_cmd_needok(send_cmd, pduhex, callback); }