FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/gsmtime.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | f40530e2d48d |
children |
line wrap: on
line source
/* * This library module implements decoding of GSM timestamps. */ #include <sys/types.h> #include <stdio.h> gsm_timestamp_decode(inbuf, outbuf) u_char *inbuf; char *outbuf; { u_char rev[7]; int i, d1, d2, tzsign; for (i = 0; i < 7; i++) { d1 = inbuf[i] & 0xF; d2 = inbuf[i] >> 4; rev[i] = (d1 << 4) | d2; } if (rev[6] & 0x80) { rev[6] &= 0x7F; tzsign = '-'; } else tzsign = '+'; sprintf(outbuf, "%02X/%02X/%02X,%02X:%02X:%02X%c%02X", rev[0], rev[1], rev[2], rev[3], rev[4], rev[5], tzsign, rev[6]); }