FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/hexdecode.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 18c692984549 |
children |
line wrap: on
line source
/* * This library module implements decoding of long hex strings, * such as SMS PDUs. */ #include <sys/types.h> #include <ctype.h> decode_hex_line(inbuf, outbuf, outmax) char *inbuf; u_char *outbuf; unsigned outmax; { char *inp = inbuf; u_char *outp = outbuf; unsigned outcnt = 0; int c, d[2], i; while (*inp) { if (!isxdigit(inp[0]) || !isxdigit(inp[1])) return(-1); if (outcnt >= outmax) break; for (i = 0; i < 2; i++) { c = *inp++; if (isdigit(c)) d[i] = c - '0'; else if (isupper(c)) d[i] = c - 'A' + 10; else d[i] = c - 'a' + 10; } *outp++ = (d[0] << 4) | d[1]; outcnt++; } return outcnt; }