FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/sms_submit8.c @ 964:a96cb97b66a2
ringtools/imy: fix duplicate definition of tdma_durations[]
The bug was reported by Vadim Yanitskiy <fixeria@osmocom.org>,
although the present fix is slightly different from the contributed
patch: because main.c doesn't need this tdma_durations[] array
at all, let's simply remove the reference to this array from main.c
rather than turn it into an extern.
I no longer remember my original thought flow that resulted (by mistake)
in tdma_durations[] being multiply defined in main.c and durations.c.
My intent might have been to define all globals in main.c and have
the reference in durations.c be an extern - and I missed that extern -
but without clear memory, I have no certainty. In any case, having
this data array defined in the same module that fills it (durations.c)
is sensible, so let's make it the new way.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 31 Aug 2023 19:38:18 +0000 |
parents | 759cb6dc501b |
children |
line wrap: on
line source
/* * This library module implements the function for constructing outgoing * SMS-SUBMIT PDUs, 8-bit version for raw data or UCS-2. */ #include <sys/types.h> #include <strings.h> make_sms_submit_pdu_8bit(da, pid, dcs, textsrc, textlen, udh, udhl, outbuf) u_char *da, *textsrc, *udh, *outbuf; unsigned textlen, udhl; { u_char *outp = outbuf; unsigned addr_field_len; unsigned udh_octets; unsigned udl; if (udh) *outp++ = 0x41; else *outp++ = 0x01; *outp++ = 0; addr_field_len = ((da[0] + 1) >> 1) + 2; bcopy(da, outp, addr_field_len); outp += addr_field_len; *outp++ = pid; *outp++ = dcs; if (udh) udh_octets = udhl + 1; else udh_octets = 0; udl = udh_octets + textlen; *outp++ = udl; if (udh) { *outp++ = udhl; bcopy(udh, outp, udhl); outp += udhl; } bcopy(textsrc, outp, textlen); outp += textlen; return (outp - outbuf); }