FreeCalypso > hg > freecalypso-tools
view loadtools/ltscript.c @ 1011:6d9b10633f10 default tip
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 6616f4e35579 |
children |
line wrap: on
line source
/* * This module contains the code that implements the loadtool scripting * functionality: init-script setting and the exec command. */ #include <sys/param.h> #include <stdio.h> #include <string.h> #include <strings.h> #include <stdlib.h> extern char default_helpers_dir[]; loadtool_exec_script(script_name, is_init_script) char *script_name; { char pathbuf[MAXPATHLEN], *openfname; FILE *f; char linebuf[512], *cp; int lineno, retval = 0; if (!is_init_script || index(script_name, '/')) openfname = script_name; else { sprintf(pathbuf, "%s/%s", default_helpers_dir, script_name); openfname = pathbuf; } f = fopen(openfname, "r"); if (!f) { perror(openfname); return(-1); } for (lineno = 1; fgets(linebuf, sizeof linebuf, f); lineno++) { cp = index(linebuf, '\n'); if (!cp) { fprintf(stderr, "%s line %d: missing newline\n", openfname, lineno); fclose(f); return(-1); } *cp = '\0'; retval = loadtool_dispatch_cmd(linebuf, 1); if (retval) break; } fclose(f); return(retval); } cmd_exec(argc, argv) char **argv; { return loadtool_exec_script(argv[1], 0); }