view loadtools/simup.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 02490e26f53d
children
line wrap: on
line source

/*
 * This module implements the stage in fc-simint where the sim-up
 * command is fed to simagent and the ATR response is parsed.
 */

#include <sys/types.h>
#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>

extern int sim_voltage_mode_1v8;

#define	MAX_ATR_BYTES	33

u_char sim_atr[MAX_ATR_BYTES];
unsigned sim_atr_len;

static
sim_up_callback(line)
	char *line;
{
	char *cp;

	puts(line);
	if (strncmp(line, "ATR:", 4))
		return(1);
	sim_atr_len = 0;
	for (cp = line + 4; *cp; cp += 3) {
		if (cp[0] != ' ' || !isxdigit(cp[1]) || !isxdigit(cp[2])) {
			fprintf(stderr,
				"error: invalid ATR line from simagent\n");
			return(1);
		}
		if (sim_atr_len >= MAX_ATR_BYTES) {
			fprintf(stderr,
				"error: ATR from simagent is too long\n");
			return(1);
		}
		sim_atr[sim_atr_len++] = decode_hex_byte(cp + 1);
	}
	return(0);
}

void
do_sim_up()
{
	char *targv[3];

	printf("Bringing up SIM interface at %s V\n",
		sim_voltage_mode_1v8 ? "1.8" : "3.0");
	targv[0] = "sim-up";
	targv[1] = sim_voltage_mode_1v8 ? "1.8" : "3";
	targv[2] = 0;
	tpinterf_make_cmd(targv);
	if (tpinterf_send_cmd() < 0)
		exit(1);
	if (tpinterf_capture_output(20, sim_up_callback))
		exit(1);
	if (!sim_atr_len) {
		fprintf(stderr, "error: no ATR returned from simagent\n");
		exit(1);
	}
}