view rvinterf/asyncshell/at.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 10f4062e049b
children
line wrap: on
line source

/*
 * Functions for the AT-over-RVTMUX interface
 */

#include <sys/types.h>
#include <sys/errno.h>
#include <stdio.h>
#include <ctype.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include <unistd.h>
#include "pktmux.h"
#include "limits.h"
#include "exitcodes.h"

extern char *rvinterf_ttyport;
extern u_char rvi_msg[];
extern int rvi_msg_len;
extern int oneshot_nowait;
extern int sock;

send_string_to_ati(str)
	char *str;
{
	unsigned len;
	u_char sendpkt[MAX_PKT_TO_TARGET+1];

	len = strlen(str);
	if (len + 1 > MAX_PKT_TO_TARGET) {
		printf("error: max pkt to target limit exceeded\n");
		return(ERROR_USAGE);
	}
	/* fill out the packet */
	sendpkt[0] = RVT_AT_HEADER;
	strcpy(sendpkt + 1, str);
	/* send it! */
	send_pkt_to_target(sendpkt, len + 1);
	return(0);
}

send_unterm_string_to_ati(str)
	char *str;
{
	unsigned len;
	u_char sendpkt[MAX_PKT_TO_TARGET+1];

	len = strlen(str);
	if (len + 2 > MAX_PKT_TO_TARGET) {
		printf("error: max pkt to target limit exceeded\n");
		return(ERROR_USAGE);
	}
	/* fill out the packet */
	sendpkt[0] = RVT_AT_HEADER;
	sendpkt[1] = 0x01;
	strcpy(sendpkt + 2, str);
	/* send it! */
	send_pkt_to_target(sendpkt, len + 2);
	return(0);
}

void
cmd_sendat(arg)
	char *arg;
{
	while (isspace(*arg))
		arg++;
	if (!*arg) {
		printf("error: missing string argument\n");
		return;
	}
	ati_rx_control(1);
	send_string_to_ati(arg);
}

void
cmd_unterm(arg)
	char *arg;
{
	while (isspace(*arg))
		arg++;
	if (!*arg) {
		printf("error: missing string argument\n");
		return;
	}
	ati_rx_control(1);
	send_unterm_string_to_ati(arg);
}

oneshot_at_command(cmd)
	char *cmd;
{
	fd_set fds;
	int rc;

	if (!oneshot_nowait) {
		if (rvinterf_ttyport)
			usleep(30000);
		init();		/* to catch the response properly */
		ati_rx_control(1);
	}
	rc = send_string_to_ati(cmd);
	if (rc)
		exit(rc);
	if (oneshot_nowait)
		exit(0);
	/* wait for response */
	for (;;) {
		FD_ZERO(&fds);
		FD_SET(sock, &fds);
		rc = select(sock+1, &fds, 0, 0, 0);
		if (rc < 0) {
			if (errno == EINTR)
				continue;
			perror("select");
			exit(ERROR_UNIX);
		}
		if (FD_ISSET(sock, &fds))
			handle_rvinterf_input();
	}
}

cmd_str_oneshot(argc, argv)
	char **argv;
{
	return oneshot_at_command(argv[1]);
}

cmd_unterm_oneshot(argc, argv)
	char **argv;
{
	return send_unterm_string_to_ati(argv[1]);
}

void
oneshot_at_check_response()
{
	if (rvi_msg_len == 4 && !strncmp(rvi_msg + 2, "OK", 2))
		exit(0);
	if (rvi_msg_len == 4 && !strncmp(rvi_msg + 2, "> ", 2))
		exit(0);
	if (rvi_msg_len == 7 && !strncmp(rvi_msg + 2, "ERROR", 5))
		exit(ERROR_TARGET);
	if (rvi_msg_len == 6 && !strncmp(rvi_msg + 2, "BUSY", 4))
		exit(ERROR_TARGET);
	if (rvi_msg_len == 12 && !strncmp(rvi_msg + 2, "NO CARRIER", 10))
		exit(ERROR_TARGET);
	if (rvi_msg_len >= 12 && !strncmp(rvi_msg + 2, "+CME ERROR", 10))
		exit(ERROR_TARGET);
	if (rvi_msg_len >= 12 && !strncmp(rvi_msg + 2, "+CMS ERROR", 10))
		exit(ERROR_TARGET);
}