view rvinterf/asyncshell/battery.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents b55a81ce7497
children
line wrap: on
line source

/*
 * Functions for sending MMI_BATTERY_IND primitives with simulated
 * battery actions.
 */

#include <sys/types.h>
#include <stdio.h>
#include <ctype.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include "pktmux.h"
#include "limits.h"
#include "exitcodes.h"

static u_char mmi_battery_ind_fixedpart[24] = {
	RVT_L23_HEADER, 0x97, 24, 0,
	0, 0, 0, 0,
	'P', 'C', 'O', ' ',
	'M', 'M', 'I', ' ',
	'M', 'M', 'I', ' ',
	0x03, 0x4E, 0, 0
};

send_mmi_battery_ind(byte1, byte2)
{
	u_char pkt[28];

	bcopy(mmi_battery_ind_fixedpart, pkt, 24);
	pkt[24] = byte1;
	pkt[25] = byte2;
	/* 2 padding bytes */
	pkt[26] = 0;
	pkt[27] = 0;
	send_pkt_to_target(pkt, 28);
	return(0);
}

cmd_batt_common(argc, argv)
	char **argv;
{
	u_char bytes[2];
	int i;
	char *endp;

	for (i = 0; i < 2; i++) {
		bytes[i] = strtoul(argv[i], &endp, 0);
		if (*endp) {
			printf("error: invalid batt argument\n");
			return(ERROR_USAGE);
		}
	}
	return send_mmi_battery_ind(bytes[0], bytes[1]);
}

void
cmd_batt_interactive(argstr)
	char *argstr;
{
	char *argv[3];
	int argc, rc;

	rc = parse_interactive_command_into_argv(argstr, argv, 2, 2, &argc);
	if (rc < 0)
		return;
	cmd_batt_common(argc, argv);
}

cmd_batt_oneshot(argc, argv)
	char **argv;
{
	return cmd_batt_common(argc - 1, argv + 1);
}