view rvinterf/etmsync/fsbasics.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 74d284add54d
children
line wrap: on
line source

/*
 * Basic FFS2 operations
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>
#include "etm.h"
#include "ffs.h"
#include "tmffs2.h"
#include "limits.h"
#include "ffslimits.h"
#include "localtypes.h"
#include "localstruct.h"
#include "exitcodes.h"

extern u_char rvi_msg[];
extern int rvi_msg_len;

cmd_ffs2ver()
{
	u_char cmdpkt[4];
	int rc;

	cmdpkt[1] = ETM_FFS2;
	cmdpkt[2] = TMFFS_VERSION;
	rc = etm_pkt_exch(cmdpkt, 2);
	if (rc)
		return(rc);
	if (rvi_msg[3]) {
		printf("FFS2 error %d\n", rvi_msg[3]);
		return(ERROR_TARGET);
	}
	if (rvi_msg_len != 7) {
		printf("error: FFS2 version response has wrong length\n");
		return(ERROR_TARGET);
	}
	printf("FFS2 version: %02X.%02X\n", rvi_msg[5], rvi_msg[4]);
	return(0);
}

void
safe_print_ls_name(name)
	char *name;
{
	char *p;
	int c;

	p = name;
	while (c = *p++) {
		if (c == '\\') {
			putchar('\\');
			putchar('\\');
		} else if (c >= ' ' && c <= '~')
			putchar(c);
		else
			printf("\\x%02X", c);
	}
	putchar('\n');
}

do_ls_short(lsarg)
	char *lsarg;
{
	u_char state[4];
	char namebuf[256];
	int nument, i, rc;

	rc = do_opendir(lsarg, state, &nument);
	if (rc)
		return(rc);
	if (!nument) {
		printf("<empty dir>\n");
		return(0);
	}
	for (i = 0; i < nument; i++) {
		rc = do_readdir(state, namebuf, sizeof namebuf);
		if (rc)
			return(rc);
		safe_print_ls_name(namebuf);
	}
	return(0);
}

cmd_ls(argc, argv)
	char **argv;
{
	if (argc == 2)
		return do_ls_short(argv[1]);
	if (strcmp(argv[1], "-l")) {
		fprintf(stderr, "usage: ls [-l] ffs_pathname\n");
		return(ERROR_USAGE);
	}
	return do_ls_long(argv[2]);
}

cmd_stat(argc, argv)
	char **argv;
{
	struct stat_info stat;
	int rc;
	char *type;

	rc = do_xlstat(argv[1], &stat);
	if (rc)
		return(rc);
	switch (stat.type) {
	case OT_FILE:
		type = "file";
		break;
	case OT_DIR:
		type = "directory";
		break;
	case OT_LINK:
		type = "symlink";
		break;
	default:
		type = "???";
	}
	printf("Type: %s%s\n", type,
		stat.flags & OF_READONLY ? ", read-only" : "");
	printf("inode %x\n", stat.inode);
	printf("size %u, space %u\n", stat.size, stat.space);
	printf("location=%x, block %d\n", stat.location, stat.block);
	return(0);
}