view rvinterf/etmsync/fsuploadrf.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 7f30f92a6e35
children
line wrap: on
line source

/*
 * upload-rf-table implementation
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>
#include "etm.h"
#include "ffs.h"
#include "tmffs2.h"
#include "limits.h"
#include "exitcodes.h"

static struct map {
	char	*format;
	char	*pathname;
	int	need_band;
} map_table[] = {
	{"adc-cal",           "/sys/adccal",             0},
	{"afcparams",         "/gsm/rf/afcparams",       0},
	{"agc-global-params", "/gsm/rf/rx/agcglobals",   0},
	{"agc-table",         "/gsm/rf/rx/agcwords",     0},
	{"tx-ramps",          "/gsm/rf/tx/ramps.%s",     1},
	{"tx-levels",         "/gsm/rf/tx/levels.%s",    1},
	{"tx-calchan",        "/gsm/rf/tx/calchan.%s",   1},
	{"tx-caltemp",        "/gsm/rf/tx/caltemp.%s",   1},
	{"rx-calchan",        "/gsm/rf/rx/calchan.%s",   1},
	{"rx-caltemp",        "/gsm/rf/rx/caltemp.%s",   1},
	{"rx-agc-params",     "/gsm/rf/rx/agcparams.%s", 1},
	{0,                   0,                         0}
};

cmd_upload_rf_table(argc, argv)
	char **argv;
{
	u_char buf[512];
	char *format, pathname[32];
	struct map *map;
	unsigned size;
	int rc;

	rc = read_rf_table_ext(argv[1], buf, 1, &format, &size);
	if (rc)
		return(rc);
	for (map = map_table; map->format; map++)
		if (!strcmp(map->format, format))
			break;
	if (!map->format) {
		printf("error: %s tables cannot be uploaded\n", format);
		return(ERROR_USAGE);
	}
	if (map->need_band) {
		if (!argv[2]) {
			printf("error: band not specified for %s table\n",
				format);
			return(ERROR_USAGE);
		}
		if (strlen(argv[2]) > 7) {
			printf("error: band name argument is too long\n");
			return(ERROR_USAGE);
		}
		sprintf(pathname, map->pathname, argv[2]);
	} else {
		if (argv[2]) {
			printf("error: band not applicable for %s table\n",
				format);
			return(ERROR_USAGE);
		}
		strcpy(pathname, map->pathname);
	}
	return write_buf_to_file(pathname, buf, size);
}