view rvinterf/old/before-rvinterf/packetrx.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents e7502631a0f9
children
line wrap: on
line source

/*
 * This module handles the lowest level of serial packet Rx
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "pktmux.h"

extern int target_fd;

#define	MAXPKT	512
u_char rxpkt[MAXPKT];
size_t rxpkt_len;

extern char pr_item[];

static int in_pkt, dle_state, toobig;

static void
process_inbyte(inb)
{
	if (!in_pkt) {
		if (inb != STX || dle_state) {
			rxpkt_len++;
			dle_state = (inb == DLE);
			return;
		}
		if (rxpkt_len) {
			sprintf(pr_item,
				"Warning: Rx %u byte%s outside of a packet",
				(unsigned)rxpkt_len, rxpkt_len != 1 ? "s" : "");
			print_item();
			rxpkt_len = 0;
		}
		in_pkt = 1;
		toobig = 0;
		return;
	}
	if (dle_state) {
		dle_state = 0;
		if (inb != STX && inb != DLE) {
			sprintf(pr_item,
				"Rx framing error: %02X after DLE\n", inb);
			print_item();
			in_pkt = 0;
			rxpkt_len = 0;
			return;
		}
		goto data;
	}
	if (inb == DLE) {
		dle_state = 1;
		return;
	} else if (inb == STX) {
		if (!rxpkt_len)
			return;
		in_pkt = 0;
		handle_rx_packet();
		rxpkt_len = 0;
		return;
	}
data:	if (rxpkt_len >= MAXPKT) {
		if (!toobig) {
			sprintf(pr_item, "Error: Rx packet too big!\n");
			print_item();
			toobig = 1;
		}
		return;
	}
	rxpkt[rxpkt_len++] = inb;
}

void
process_serial_rx()
{
	u_char rdbuf[512];
	int cc, i;

	cc = read(target_fd, rdbuf, sizeof rdbuf);
	if (cc <= 0) {
		perror("Error/EOF reading from target");
		exit(1);
	}
	for (i = 0; i < cc; i++)
		process_inbyte(rdbuf[i]);
}