view rvinterf/tmsh/abbtm3.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 74b9aeb25d79
children
line wrap: on
line source

/*
 * Old TM3 versions of ABB register read and write commands
 */

#include <sys/types.h>
#include <stdio.h>
#include <string.h>
#include <strings.h>
#include <stdlib.h>
#include "pktmux.h"
#include "limits.h"
#include "localtypes.h"
#include "tm3.h"
#include "exitcodes.h"

extern u_char rvi_msg[];
extern int rvi_msg_len;

void
handle_oabbr_response()
{
	char buf[80];
	unsigned val;

	if (rvi_msg[3]) {
		if (rvi_msg_len == 5) {
			sprintf(buf, "oabbr error %u (0x%02X)",
				rvi_msg[3], rvi_msg[3]);
			async_msg_output(buf);
		} else
			print_etm_pkt_raw("oabbr long error response");
		return;
	}
	if (rvi_msg_len != 7) {
		print_etm_pkt_raw("oabbr response wrong length");
		return;
	}
	val = rvi_msg[4] | (rvi_msg[5] << 8);
	sprintf(buf, "oabbr: %04X", val);
	async_msg_output(buf);
}

cmd_oabbr(argc, argv)
	char **argv;
{
	u32 page, reg;
	u_char cmdpkt[5];

	page = strtoul(argv[1], 0, 0);
	reg = strtoul(argv[2], 0, 0);
	if (page > 1 || reg > 31) {
		printf("error: argument(s) out of range\n");
		return(ERROR_USAGE);
	}
	cmdpkt[1] = CODEC_READ;
	cmdpkt[2] = page << 5 | reg;
	cmdpkt[3] = 0;
	send_etm_cmd(cmdpkt, 3);
	return(0);
}

cmd_oabbw(argc, argv)
	char **argv;
{
	u32 page, reg, val;
	u_char cmdpkt[7];

	page = strtoul(argv[1], 0, 0);
	reg = strtoul(argv[2], 0, 0);
	val = strtoul(argv[3], 0, 16);
	if (page > 1 || reg > 31 || val > 0x3FF) {
		printf("error: argument(s) out of range\n");
		return(ERROR_USAGE);
	}
	cmdpkt[1] = CODEC_WRITE;
	cmdpkt[2] = page << 5 | reg;
	cmdpkt[3] = 0;
	cmdpkt[4] = val;
	cmdpkt[5] = val >> 8;
	send_etm_cmd(cmdpkt, 5);
	return(0);
}