view target-utils/libcommon/cmd_memdump_human.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents 9214118ae941
children
line wrap: on
line source

/*
 * This is a human-oriented memory dump command.  The dump is given in
 * both hex and ASCII, with readable spacing.
 */

#include <sys/types.h>
#include "types.h"

void
cmd_memdump_human(argbulk)
	char *argbulk;
{
	char *argv[3];
	u_long start, length;
	u_long offset;
	u_char intbuf[16];
	int i, c;

	if (parse_args(argbulk, 2, 2, argv, 0) < 0)
		return;
	if (parse_hexarg(argv[0], 8, &start) < 0) {
		printf("ERROR: arg1 must be a valid 32-bit hex address\n");
		return;
	}
	if (parse_hexarg(argv[1], 8, &length) < 0) {
	    printf("ERROR: arg2 must be a valid 32-bit hex value (length)\n");
		return;
	}
	if (start & 0xF || length & 0xF) {
	    printf("ERROR: implementation limit: 16-byte alignment required\n");
		return;
	}
	for (offset = 0; offset < length; offset += 0x10) {
		memcpy(intbuf, start + offset, 0x10);
		printf("%08X: ", start + offset);
		for (i = 0; i < 16; i++) {
			printf("%02X ", intbuf[i]);
			if ((i & 3) == 3)
				putchar(' ');
		}
		for (i = 0; i < 16; i++) {
			c = intbuf[i];
			if (c >= ' ' && c <= '~')
				putchar(c);
			else
				putchar('.');
		}
		putchar('\n');
	}
}