FreeCalypso > hg > freecalypso-tools
view target-utils/libcommon/dispatch.c @ 1011:6d9b10633f10 default tip
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | e7502631a0f9 |
children |
line wrap: on
line source
/* * This module implements the dispatch of interactively entered * commands to their respective implementation functions via cmdtab. */ #include "cmdtab.h" extern char command[]; extern struct cmdtab cmdtab[]; void command_dispatch() { char *cp, *np; struct cmdtab *tp; for (cp = command; *cp == ' '; cp++) ; if (!*cp) return; for (np = cp; *cp && *cp != ' '; cp++) ; if (*cp) *cp++ = '\0'; for (tp = cmdtab; tp->cmd; tp++) if (!strcmp(tp->cmd, np)) break; if (tp->func) tp->func(cp); else printf("ERROR: unknown or unimplemented command\n"); }