view target-utils/simagent/spenh.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents b761029f9c03
children
line wrap: on
line source

#include <sys/types.h>
#include <strings.h>
#include "types.h"
#include "simregs.h"

extern int sim_if_state;
extern u16 conf1_reg;

const u8 pts_for_spenh[4] = {0xFF, 0x10, 0x94, 0x7B};

void
cmd_spenh()
{
	int rc;
	unsigned count;

	if (sim_if_state != 2) {
		printf("ERROR: SIM interface is not up\n");
		return;
	}
	if (conf1_reg & SIM_CONF1_ETU) {
		printf("ERROR: speed enhancement is already on\n");
		return;
	}
	rc = flush_rx_fifo();
	if (rc < 0)
		return;
	rc = send_to_sim(pts_for_spenh, 4);
	if (rc < 0)
		return;
	for (count = 0; count < 4; count++) {
		rc = rx_sim_byte_hl();
		if (rc < 0)
			return;
		if (rc != pts_for_spenh[count]) {
			printf("ERROR: PTS response does not match request\n");
			return;
		}
	}
	SIMREGS.conf1 = conf1_reg |= SIM_CONF1_ETU;
}

void
cmd_set_spenh(argbulk)
	char *argbulk;
{
	char *argv[2];

	if (parse_args(argbulk, 1, 1, argv, 0) < 0)
		return;
	if (!strcmp(argv[0], "0"))
		SIMREGS.conf1 = conf1_reg &= ~SIM_CONF1_ETU;
	else if (!strcmp(argv[0], "1"))
		SIMREGS.conf1 = conf1_reg |= SIM_CONF1_ETU;
	else
		printf("ERROR: \"0\" or \"1\" argument expected\n");
}