view uptools/atcmd/smsend_cmgw.c @ 1011:6d9b10633f10 default tip

etmsync Pirelli IMEI retrieval: fix poor use of printf() Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct where a static-allocated string was passed to printf() without any format arguments causes newer compilers to report a security problem. Given that formatted output is not needed here, just fixed string output, change printf() to fputs(), and direct the error message to stderr while at it.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 23 May 2024 17:29:57 +0000
parents dc2fd8e6f42c
children
line wrap: on
line source

/*
 * The handling of +CMGW responses and send-after-write for fcup-smsend
 * family is implemented here.
 */

#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <strings.h>
#include "../../rvinterf/include/exitcodes.h"
#include "resp_parse.h"

extern char at_response[];
extern int sms_write_mode;

struct saw_rec {
	unsigned	msgid;
	struct saw_rec	*next;
};

struct saw_rec *sendafterwr_head, **sendafterwr_tail = &sendafterwr_head;

add_sendafterwr_record(msgid)
	unsigned msgid;
{
	struct saw_rec *rec;

	rec = malloc(sizeof(struct saw_rec));
	if (!rec) {
		perror("malloc for send-after-write record");
		exit(ERROR_UNIX);
	}
	rec->msgid = msgid;
	rec->next = 0;
	*sendafterwr_tail = rec;
	sendafterwr_tail = &rec->next;
}

cmgw_callback()
{
	struct resp_field fields[1];
	int cc;

	/* skip empty lines */
	if (!at_response[1])
		return;
	/* if not empty, it MUST be +CMGW */
	if (strncmp(at_response+1, "+CMGW: ", 7)) {
		fprintf(stderr, "error: response from target is not +CMGW\n");
		exit(ERROR_TARGET);
	}
	if (sms_write_mode == 2) {
		puts(at_response+1);
		return;
	}
	if (parse_structured_response(at_response+8, fields, 1) != 1) {
malformed:	fprintf(stderr, "error: malformed +CMGW response\n");
		exit(ERROR_TARGET);
	}
	if (fields[0].type != RESP_FIELD_NUMBER)
		goto malformed;
	add_sendafterwr_record(fields[0].num);
}

sendafterwr_process()
{
	struct saw_rec *rec;
	char cmss_cmd[32];

	if (!sendafterwr_head) {
		fprintf(stderr,
			"error: no +CMGW response received from target\n");
		exit(ERROR_TARGET);
	}
	if (sendafterwr_head->next)
		atinterf_exec_cmd_needok("AT+CMMS=1", (char *) 0, (void *) 0);
	for (rec = sendafterwr_head; rec; rec = rec->next) {
		sprintf(cmss_cmd, "AT+CMSS=%u", rec->msgid);
		atinterf_exec_cmd_needok(cmss_cmd, (char *) 0, (void *) 0);
	}
	if (sendafterwr_head->next)
		atinterf_exec_cmd_needok("AT+CMMS=0", (char *) 0, (void *) 0);
}