FreeCalypso > hg > freecalypso-tools
view uptools/libcoding/sms_submit8.c @ 1011:6d9b10633f10 default tip
etmsync Pirelli IMEI retrieval: fix poor use of printf()
Bug reported by Vadim Yanitskiy <fixeria@osmocom.org>: the construct
where a static-allocated string was passed to printf() without any
format arguments causes newer compilers to report a security problem.
Given that formatted output is not needed here, just fixed string
output, change printf() to fputs(), and direct the error message
to stderr while at it.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 23 May 2024 17:29:57 +0000 |
parents | 759cb6dc501b |
children |
line wrap: on
line source
/* * This library module implements the function for constructing outgoing * SMS-SUBMIT PDUs, 8-bit version for raw data or UCS-2. */ #include <sys/types.h> #include <strings.h> make_sms_submit_pdu_8bit(da, pid, dcs, textsrc, textlen, udh, udhl, outbuf) u_char *da, *textsrc, *udh, *outbuf; unsigned textlen, udhl; { u_char *outp = outbuf; unsigned addr_field_len; unsigned udh_octets; unsigned udl; if (udh) *outp++ = 0x41; else *outp++ = 0x01; *outp++ = 0; addr_field_len = ((da[0] + 1) >> 1) + 2; bcopy(da, outp, addr_field_len); outp += addr_field_len; *outp++ = pid; *outp++ = dcs; if (udh) udh_octets = udhl + 1; else udh_octets = 0; udl = udh_octets + textlen; *outp++ = udl; if (udh) { *outp++ = udhl; bcopy(udh, outp, udhl); outp += udhl; } bcopy(textsrc, outp, textlen); outp += textlen; return (outp - outbuf); }