FreeCalypso > hg > gsm-codec-lib
annotate libtest/tw5reader.h @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | 4d2cccaeb4a7 |
children |
rev | line source |
---|---|
10
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
522
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
2 * This header file defines the interface to our reader function for |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
3 * hexadecimal RTP frame sequence files in TW-TS-005 format. |
10
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * |
522
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
5 * twts005_read_frame() return values are: |
10
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 * 1 = successfully read valid frame |
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 * 0 = normal EOF |
522
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
8 * -1 = read line with invalid content |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
9 * -2 = line too long or missing newline |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
10 * |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
11 * The reader function skips blank, whitespace-only and comment lines, |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
12 * returning only actual frames. lineno variable must be initialized to 0 |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
13 * by the application program, but not touched otherwise. In case of an |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
14 * error, this variable will hold the line number at which the error was |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
15 * encountered. |
10
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 */ |
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 |
522
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
18 #define TWTS005_MAX_FRAME 40 |
10
820d88b97924
libtest: implement binary file reader
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 |
522
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
20 int twts005_read_frame(FILE *hexf, unsigned *lineno, uint8_t *frame, |
4d2cccaeb4a7
libtest: implement TW-TS-005 reader function
Mychaela Falconia <falcon@freecalypso.org>
parents:
10
diff
changeset
|
21 unsigned *lenp); |