FreeCalypso > hg > gsm-codec-lib
annotate libtest/tw5writer.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | 0daaae66b3f6 |
children |
rev | line source |
---|---|
539
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * Here we implement our emit_hex_frame() function. |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 */ |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #include <stdio.h> |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include <stdint.h> |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 #include "tw5writer.h" |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 void emit_hex_frame(FILE *outf, const uint8_t *frame, unsigned nbytes) |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 { |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 unsigned n; |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 for (n = 0; n < nbytes; n++) |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 fprintf(outf, "%02X", frame[n]); |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 putc('\n', outf); |
0daaae66b3f6
libtest: add TW-TS-005 write helper function
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 } |