FreeCalypso > hg > gsm-codec-lib
annotate libtwamr/prm2bits.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | ffd48f0a2ab5 |
children |
rev | line source |
---|---|
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
400
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
2 * A cleaner reimplementation of AMR Prm2bits() function. |
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 */ |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #include "typedef.h" |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include "namespace.h" |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 #include "bitno.h" |
400
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
8 #include "prm2bits.h" |
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 |
400
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
10 void Prm2bits(enum Mode mode, const Word16 prm[], Word16 bits[]) |
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 { |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 const Word16 *t = bitno[mode]; |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 unsigned nparam = prmno[mode]; |
400
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
14 unsigned n, p, mask; |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
15 Word16 *b = bits; |
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 for (n = 0; n < nparam; n++) { |
400
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
18 p = prm[n]; |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
19 mask = 1 << (*t++ - 1); |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
20 for (; mask; mask >>= 1) { |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
21 if (p & mask) |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
22 *b++ = 1; |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
23 else |
ffd48f0a2ab5
libtwamr: implement Prm2bits() like Bits2prm()
Mychaela Falconia <falcon@freecalypso.org>
parents:
254
diff
changeset
|
24 *b++ = 0; |
254
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
25 } |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 } |
f931e704adc5
libtwamr: bits and parameter packing
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 } |