annotate amrefr/encode-r.c @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents 0c4e1bc06740
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
2 * amrefr-encode-r is a counterpart to gsmefr-encode-r, implementing
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
3 * "alternative EFR" by way of libtwamr. Unlike standard gsmefr-encode-r,
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
4 * there is no -d option and no DTX support in this version.
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 */
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdio.h>
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <stdint.h>
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include <stdlib.h>
121
b51295fcbbae gsmefr-encode utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 14
diff changeset
10 #include <string.h>
b51295fcbbae gsmefr-encode utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 14
diff changeset
11 #include <strings.h>
b51295fcbbae gsmefr-encode utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 14
diff changeset
12 #include "../libgsmefr/gsm_efr.h"
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
13 #include "../libtwamr/tw_amr.h"
156
3f3674c27840 gsmefr-encode-r utility put together
Mychaela Falconia <falcon@freecalypso.org>
parents: 121
diff changeset
14 #include "../libtest/roberead.h"
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 main(argc, argv)
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 char **argv;
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 {
156
3f3674c27840 gsmefr-encode-r utility put together
Mychaela Falconia <falcon@freecalypso.org>
parents: 121
diff changeset
19 FILE *inf, *binf;
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
20 struct amr_encoder_state *state;
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 int16_t pcm[160];
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
22 struct amr_param_frame amr_frame;
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
23 uint8_t efr_frame[EFR_RTP_FRAME_LEN];
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
24 int rc;
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
26 if (argc != 3) {
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
27 fprintf(stderr, "usage: %s input.robe output.gsmx\n", argv[0]);
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 exit(1);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 }
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
30 inf = fopen(argv[1], "r");
156
3f3674c27840 gsmefr-encode-r utility put together
Mychaela Falconia <falcon@freecalypso.org>
parents: 121
diff changeset
31 if (!inf) {
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
32 perror(argv[1]);
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 exit(1);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 }
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
35 binf = fopen(argv[2], "w");
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36 if (!binf) {
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
37 perror(argv[2]);
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38 exit(1);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 }
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
40 state = amr_encoder_create(0, 0);
121
b51295fcbbae gsmefr-encode utility written
Mychaela Falconia <falcon@freecalypso.org>
parents: 14
diff changeset
41 if (!state) {
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
42 perror("amr_encoder_create()");
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
43 exit(1);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
44 }
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
45 for (;;) {
156
3f3674c27840 gsmefr-encode-r utility put together
Mychaela Falconia <falcon@freecalypso.org>
parents: 121
diff changeset
46 rc = robe_get_pcm_block(inf, pcm);
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
47 if (!rc)
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
48 break;
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
49 amr_encode_frame(state, MR122, pcm, &amr_frame);
466
0c4e1bc06740 amrefr-encode-r: use the new DHF xform that matches T-Mobile
Mychaela Falconia <falcon@freecalypso.org>
parents: 438
diff changeset
50 amr_dhf_subst_efr2(&amr_frame, pcm);
438
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
51 EFR_params2frame(amr_frame.param, efr_frame);
1bf1bbcef763 amrefr: implement amrefr-encode-r utility
Mychaela Falconia <falcon@freecalypso.org>
parents: 294
diff changeset
52 fwrite(efr_frame, 1, sizeof efr_frame, binf);
14
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
53 }
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
54 fclose(binf);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
55 exit(0);
69ed7af28473 gsmfr-encode test program written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
56 }