FreeCalypso > hg > gsm-codec-lib
annotate libgsmefr/enc_create.c @ 581:e2d5cad04cbf
libgsmhr1 RxFE: store CN R0+LPC separately from speech
In the original GSM 06.06 code the ECU for speech mode is entirely
separate from the CN generator, maintaining separate state. (The
main intertie between them is the speech vs CN state variable,
distinguishing between speech and CN BFIs, in addition to the
CN-specific function of distinguishing between initial and update
SIDs.)
In the present RxFE implementation I initially thought that we could
use the same saved_frame buffer for both ECU and CN, overwriting
just the first 4 params (R0 and LPC) when a valid SID comes in.
However, I now realize it was a bad idea: the original code has a
corner case (long sequence of speech-mode BFIs to put the ECU in
state 6, then SID and CN-mode BFIs, then a good speech frame) that
would be broken by that buffer reuse approach. We could eliminate
this corner case by resetting the ECU state when passing through
a CN insertion period, but doing so would needlessly increase
the behavioral diffs between GSM 06.06 and our version.
Solution: use a separate CN-specific buffer for CN R0+LPC parameters,
and match the behavior of GSM 06.06 code in this regard.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 13 Feb 2025 10:02:45 +0000 |
parents | 23656d874524 |
children |
rev | line source |
---|---|
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * In this module we implement allocation and initialization |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
3 * of state structures for our GSM EFR encoder. |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 */ |
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 |
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include <stdlib.h> |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
7 #include "gsm_efr.h" |
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
8 #include "typedef.h" |
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
9 #include "cnst.h" |
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
10 #include "enc_state.h" |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
541
23656d874524
libgsmefr: add const words with struct sizes
Mychaela Falconia <falcon@freecalypso.org>
parents:
51
diff
changeset
|
12 const unsigned EFR_encoder_state_size = sizeof(struct EFR_encoder_state); |
23656d874524
libgsmefr: add const words with struct sizes
Mychaela Falconia <falcon@freecalypso.org>
parents:
51
diff
changeset
|
13 |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
14 struct EFR_encoder_state *EFR_encoder_create(int dtx) |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 { |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
16 struct EFR_encoder_state *st; |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
18 st = malloc(sizeof(struct EFR_encoder_state)); |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 if (st) |
51
722959d9410f
libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
4
diff
changeset
|
20 EFR_encoder_reset(st, dtx); |
3
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 return st; |
3cd5ad24b1d4
libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 } |