annotate libgsmefr/sid_insert.c @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents b4db5366b595
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
37
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * EFR_insert_sid_codeword() inserts the 95 bit wide SID codeword into
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * an EFR frame in RTP encoding, normally as part of EFR_encode_frame()
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * processing right after EFR_params2frame().
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 */
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include "gsm_efr.h"
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 void EFR_insert_sid_codeword(uint8_t *frame)
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 {
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 frame[6] |= 0x6F;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 frame[7] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 frame[8] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 frame[9] |= 0x80;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 frame[12] |= 0x3B;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 frame[13] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 frame[14] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 frame[15] |= 0xE0;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 frame[19] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 frame[20] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 frame[21] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 frame[25] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 frame[26] |= 0xFC;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 frame[27] = 0xFF;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 frame[28] |= 0xC0;
b4db5366b595 libgsmefr: implement SID code word insertion
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 }