FreeCalypso > hg > gsm-codec-lib
annotate libgsmhr1/paramval_cod.c @ 581:e2d5cad04cbf
libgsmhr1 RxFE: store CN R0+LPC separately from speech
In the original GSM 06.06 code the ECU for speech mode is entirely
separate from the CN generator, maintaining separate state. (The
main intertie between them is the speech vs CN state variable,
distinguishing between speech and CN BFIs, in addition to the
CN-specific function of distinguishing between initial and update
SIDs.)
In the present RxFE implementation I initially thought that we could
use the same saved_frame buffer for both ECU and CN, overwriting
just the first 4 params (R0 and LPC) when a valid SID comes in.
However, I now realize it was a bad idea: the original code has a
corner case (long sequence of speech-mode BFIs to put the ECU in
state 6, then SID and CN-mode BFIs, then a good speech frame) that
would be broken by that buffer reuse approach. We could eliminate
this corner case by resetting the ECU state when passing through
a CN insertion period, but doing so would needlessly increase
the behavioral diffs between GSM 06.06 and our version.
Solution: use a separate CN-specific buffer for CN R0+LPC parameters,
and match the behavior of GSM 06.06 code in this regard.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 13 Feb 2025 10:02:45 +0000 |
parents | 03a40ac2e931 |
children |
rev | line source |
---|---|
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * The function implemented in this module examines a frame of 20 int16_t words |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * that corresponds to GSM-HR encoder output format, and checks if the unused |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * upper bits of each int16_t word are cleared as they should be. |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 * This function should be used when reading from ETSI-format *.cod files, |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 * to guard against reading garbage or wrong endian. |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 */ |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 #include <stdint.h> |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 #include "tw_gsmhr.h" |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 int gsmhr_check_encoder_params(const int16_t *params) |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 { |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 if (params[18] & 0xFFFE) |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 return -1; |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 if (params[19] & 0xFFFE) |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 return -1; |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 return gsmhr_check_common_params(params); |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 } |