annotate libgsmhr1/sid_detect.c @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents aaf4dec8bee0
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
494
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * The function in this module implements detection of perfect, error-free
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * HRv1 SID frames in TS 101 318 raw packed format. If SID is detected,
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * the return value is 2: the code for valid SID per GSM 06.41.
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 */
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdint.h>
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <string.h>
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include "tw_gsmhr.h"
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 int gsmhr_ts101318_is_perfect_sid(const uint8_t *payload)
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 {
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 static const uint8_t all_ff_bytes[9] = {0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 0xFF, 0xFF, 0xFF, 0xFF};
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 if ((payload[4] & 0x7F) != 0x7F)
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 return 0;
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 if (memcmp(payload + 5, all_ff_bytes, 9) == 0)
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 return 2;
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 else
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 return 0;
aaf4dec8bee0 libgsmhr1: implement perfect SID detection
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 }