annotate libgsmhr1/sid_reset.c @ 581:e2d5cad04cbf

libgsmhr1 RxFE: store CN R0+LPC separately from speech In the original GSM 06.06 code the ECU for speech mode is entirely separate from the CN generator, maintaining separate state. (The main intertie between them is the speech vs CN state variable, distinguishing between speech and CN BFIs, in addition to the CN-specific function of distinguishing between initial and update SIDs.) In the present RxFE implementation I initially thought that we could use the same saved_frame buffer for both ECU and CN, overwriting just the first 4 params (R0 and LPC) when a valid SID comes in. However, I now realize it was a bad idea: the original code has a corner case (long sequence of speech-mode BFIs to put the ECU in state 6, then SID and CN-mode BFIs, then a good speech frame) that would be broken by that buffer reuse approach. We could eliminate this corner case by resetting the ECU state when passing through a CN insertion period, but doing so would needlessly increase the behavioral diffs between GSM 06.06 and our version. Solution: use a separate CN-specific buffer for CN R0+LPC parameters, and match the behavior of GSM 06.06 code in this regard.
author Mychaela Falconia <falcon@freecalypso.org>
date Thu, 13 Feb 2025 10:02:45 +0000
parents aee13079db3c
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
495
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * The function in this module implements reset of HRv1 SID codeword,
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * for rejuvenating SID frames that may have been corrupted, but were still
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * accepted as valid SID.
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 */
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 #include <stdint.h>
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include <string.h>
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 #include "tw_gsmhr.h"
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 void gsmhr_ts101318_set_sid_codeword(uint8_t *payload)
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 {
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 payload[4] |= 0x7F;
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 memset(payload + 5, 0xFF, 9);
aee13079db3c libgsmhr1: implement SID reset
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 }