annotate libgsmefr/dec_create.c @ 242:f081a6850fb5

libgsmfrp: new refined implementation The previous implementation exhibited the following defects, which are now fixed: 1) The last received valid SID was cached forever for the purpose of handling future invalid SIDs - we could have received some valid SID ages ago, then lots of speech or NO_DATA, and if we then get an invalid SID, we would resurrect the last valid SID from ancient history - a bad design. In our new design, we handle invalid SID based on the current state, much like BFI. 2) GSM 06.11 spec says clearly that after the second lost SID (received BFI=1 && TAF=1 in CN state) we need to gradually decrease the output level, rather than jump directly to emitting silence frames - we previously failed to implement such logic. 3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes in a SID frame. What should we do if we receive an otherwise valid SID frame with different Xmaxc? Our previous approach would replicate this Xmaxc oddity in every subsequent generated CN frame, which is rather bad. In our new design, the very first CN frame (which can be seen as a transformation of the SID frame itself) retains the original 4 distinct Xmaxc, but all subsequent CN frames are based on the Xmaxc from the last subframe of the most recent SID.
author Mychaela Falconia <falcon@freecalypso.org>
date Tue, 09 May 2023 05:16:31 +0000
parents 722959d9410f
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * In this module we implement allocation and initialization
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
3 * of state structures for our GSM EFR decoder.
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 */
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 #include <stdlib.h>
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
7 #include "gsm_efr.h"
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
8 #include "typedef.h"
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
9 #include "cnst.h"
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
10 #include "dec_state.h"
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
12 struct EFR_decoder_state *EFR_decoder_create(void)
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 {
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
14 struct EFR_decoder_state *st;
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
16 st = malloc(sizeof(struct EFR_decoder_state));
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 if (st)
51
722959d9410f libgsmefr: implement EFR_{en,de}coder_create() functions
Mychaela Falconia <falcon@freecalypso.org>
parents: 4
diff changeset
18 EFR_decoder_reset(st);
3
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 return st;
3cd5ad24b1d4 libgsmfrp: implement internal state
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 }