annotate libgsmefr/preemph.c @ 242:f081a6850fb5

libgsmfrp: new refined implementation The previous implementation exhibited the following defects, which are now fixed: 1) The last received valid SID was cached forever for the purpose of handling future invalid SIDs - we could have received some valid SID ages ago, then lots of speech or NO_DATA, and if we then get an invalid SID, we would resurrect the last valid SID from ancient history - a bad design. In our new design, we handle invalid SID based on the current state, much like BFI. 2) GSM 06.11 spec says clearly that after the second lost SID (received BFI=1 && TAF=1 in CN state) we need to gradually decrease the output level, rather than jump directly to emitting silence frames - we previously failed to implement such logic. 3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes in a SID frame. What should we do if we receive an otherwise valid SID frame with different Xmaxc? Our previous approach would replicate this Xmaxc oddity in every subsequent generated CN frame, which is rather bad. In our new design, the very first CN frame (which can be seen as a transformation of the SID frame itself) retains the original 4 distinct Xmaxc, but all subsequent CN frames are based on the Xmaxc from the last subframe of the most recent SID.
author Mychaela Falconia <falcon@freecalypso.org>
date Tue, 09 May 2023 05:16:31 +0000
parents 9aef9e54b19d
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*---------------------------------------------------------------------*
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 * routine preemphasis() *
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 * ~~~~~~~~~~~~~~~~~~~~~ *
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 * Preemphasis: filtering through 1 - g z^-1 *
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 *---------------------------------------------------------------------*/
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
7 #include "gsm_efr.h"
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 #include "typedef.h"
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
9 #include "namespace.h"
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 #include "basic_op.h"
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
11 #include "no_count.h"
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
12 #include "sig_proc.h"
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
13 #include "cnst.h"
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
14 #include "dec_state.h"
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 void preemphasis (
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
17 struct EFR_decoder_state *st,
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 Word16 *signal, /* (i/o) : input signal overwritten by the output */
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 Word16 g, /* (i) : preemphasis coefficient */
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 Word16 L /* (i) : size of filtering */
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 )
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 {
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 Word16 *p1, *p2, temp, i;
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
25 p1 = signal + L - 1;
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
26 p2 = p1 - 1;
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
27 temp = *p1;
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 for (i = 0; i <= L - 2; i++)
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 {
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
31 *p1 = sub (*p1, mult (g, *p2--));
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 p1--;
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 }
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
35 *p1 = sub (*p1, mult (g, st->mem_pre));
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
36
86
9aef9e54b19d libgsmefr: preemph.c compiles
Mychaela Falconia <falcon@freecalypso.org>
parents: 53
diff changeset
37 st->mem_pre = temp;
53
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
38
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
39 return;
49dd1ac8e75b libgsmefr: import most *.c files from ETSI source
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
40 }