annotate libgsmfrp/Makefile @ 242:f081a6850fb5

libgsmfrp: new refined implementation The previous implementation exhibited the following defects, which are now fixed: 1) The last received valid SID was cached forever for the purpose of handling future invalid SIDs - we could have received some valid SID ages ago, then lots of speech or NO_DATA, and if we then get an invalid SID, we would resurrect the last valid SID from ancient history - a bad design. In our new design, we handle invalid SID based on the current state, much like BFI. 2) GSM 06.11 spec says clearly that after the second lost SID (received BFI=1 && TAF=1 in CN state) we need to gradually decrease the output level, rather than jump directly to emitting silence frames - we previously failed to implement such logic. 3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes in a SID frame. What should we do if we receive an otherwise valid SID frame with different Xmaxc? Our previous approach would replicate this Xmaxc oddity in every subsequent generated CN frame, which is rather bad. In our new design, the very first CN frame (which can be seen as a transformation of the SID frame itself) retains the original 4 distinct Xmaxc, but all subsequent CN frames are based on the Xmaxc from the last subframe of the most recent SID.
author Mychaela Falconia <falcon@freecalypso.org>
date Tue, 09 May 2023 05:16:31 +0000
parents a48ddaa0f9a7
children 6ac547f0b903
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
2
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 CC= gcc
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 CFLAGS= -O2
108
3b64f255689a libgsmfrp: factor out PRNG into its own module,
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
3 OBJS= bad_frame.o comfort_noise.o good_frame.o prng.o sidclass.o \
3b64f255689a libgsmfrp: factor out PRNG into its own module,
Mychaela Falconia <falcon@freecalypso.org>
parents: 22
diff changeset
4 silence_frame.o state.o
241
a48ddaa0f9a7 libgsmfrp/Makefile: add header file dependency
Mychaela Falconia <falcon@freecalypso.org>
parents: 108
diff changeset
5 HDRS= gsm_fr_preproc.h internal.h
2
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 LIB= libgsmfrp.a
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7
20
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
8 INSTALL_PREFIX= /usr/local
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
9
2
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 all: ${LIB}
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
241
a48ddaa0f9a7 libgsmfrp/Makefile: add header file dependency
Mychaela Falconia <falcon@freecalypso.org>
parents: 108
diff changeset
12 ${OBJS}: ${HDRS}
a48ddaa0f9a7 libgsmfrp/Makefile: add header file dependency
Mychaela Falconia <falcon@freecalypso.org>
parents: 108
diff changeset
13
2
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 ${LIB}: ${OBJS}
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 ar rcu $@ ${OBJS}
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 ranlib $@
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
20
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
18 install:
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
19 mkdir -p ${INSTALL_PREFIX}/include
22
3db7af1249cb libgsmfrp/Makefile: correct modes for library install
Mychaela Falconia <falcon@freecalypso.org>
parents: 20
diff changeset
20 install -c -m 444 gsm_fr_preproc.h ${INSTALL_PREFIX}/include
20
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
21 mkdir -p ${INSTALL_PREFIX}/lib
22
3db7af1249cb libgsmfrp/Makefile: correct modes for library install
Mychaela Falconia <falcon@freecalypso.org>
parents: 20
diff changeset
22 install -c -m 444 ${LIB} ${INSTALL_PREFIX}/lib
20
93ed41fb4038 libgsmfrp/Makefile: add install
Mychaela Falconia <falcon@freecalypso.org>
parents: 6
diff changeset
23
2
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 clean:
2b5770c715ee libgsmfrp: compiling utility functions
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 rm -f *.[oa] errs