FreeCalypso > hg > gsm-codec-lib
annotate libgsmfrp/good_frame.c @ 242:f081a6850fb5
libgsmfrp: new refined implementation
The previous implementation exhibited the following defects,
which are now fixed:
1) The last received valid SID was cached forever for the purpose of
handling future invalid SIDs - we could have received some valid
SID ages ago, then lots of speech or NO_DATA, and if we then get
an invalid SID, we would resurrect the last valid SID from ancient
history - a bad design. In our new design, we handle invalid SID
based on the current state, much like BFI.
2) GSM 06.11 spec says clearly that after the second lost SID
(received BFI=1 && TAF=1 in CN state) we need to gradually decrease
the output level, rather than jump directly to emitting silence
frames - we previously failed to implement such logic.
3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes
in a SID frame. What should we do if we receive an otherwise valid
SID frame with different Xmaxc? Our previous approach would
replicate this Xmaxc oddity in every subsequent generated CN frame,
which is rather bad. In our new design, the very first CN frame
(which can be seen as a transformation of the SID frame itself)
retains the original 4 distinct Xmaxc, but all subsequent CN frames
are based on the Xmaxc from the last subframe of the most recent SID.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 09 May 2023 05:16:31 +0000 |
parents | 4812e00bc100 |
children |
rev | line source |
---|---|
5
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * In this module we implement preprocessing of received good frames. |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 */ |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #include <stdint.h> |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #include <string.h> |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 #include "gsm_fr_preproc.h" |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 #include "internal.h" |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 void gsmfr_preproc_good_frame(struct gsmfr_preproc_state *st, gsm_byte *frame) |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 { |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 int sid; |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 /* always set correct magic */ |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 frame[0] = 0xD0 | frame[0] & 0x0F; |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 /* now classify by SID */ |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 sid = gsmfr_preproc_sid_classify(frame); |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 switch (sid) { |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 case 0: /* good speech frame */ |
242
f081a6850fb5
libgsmfrp: new refined implementation
Mychaela Falconia <falcon@freecalypso.org>
parents:
5
diff
changeset
|
20 st->rx_state = SPEECH; |
5
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 memcpy(&st->speech_frame, frame, sizeof(gsm_frame)); |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 return; |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 case 1: /* invalid SID frame */ |
242
f081a6850fb5
libgsmfrp: new refined implementation
Mychaela Falconia <falcon@freecalypso.org>
parents:
5
diff
changeset
|
24 /* state-dependent handling, similar to BFI */ |
f081a6850fb5
libgsmfrp: new refined implementation
Mychaela Falconia <falcon@freecalypso.org>
parents:
5
diff
changeset
|
25 gsmfr_preproc_invalid_sid(st, frame); |
5
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
26 return; |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 case 2: /* valid SID frame */ |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
28 st->rx_state = COMFORT_NOISE; |
242
f081a6850fb5
libgsmfrp: new refined implementation
Mychaela Falconia <falcon@freecalypso.org>
parents:
5
diff
changeset
|
29 gsmfr_preproc_sid2cn(st, frame); |
5
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
30 return; |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
31 } |
4812e00bc100
libgsmfrp: implement handling of good frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
32 } |