FreeCalypso > hg > gsm-codec-lib
annotate libgsmhr1/paramval_dec.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | 67b13a6a63c9 |
children |
rev | line source |
---|---|
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
514
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
2 * The function implemented in this module examines a frame of 22 int16_t words |
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
3 * that corresponds to GSM-HR decoder input format, and checks if the unused |
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * upper bits of each int16_t word are cleared as they should be. |
514
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
5 * This function should be used when reading from ETSI-format *.dec files, |
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 * to guard against reading garbage or wrong endian. |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 */ |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 #include <stdint.h> |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 #include "tw_gsmhr.h" |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 |
514
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
12 int gsmhr_check_decoder_params(const int16_t *params) |
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 { |
514
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
14 if (params[18] < 0 || params[18] > 2) /* BFI */ |
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
15 return -1; |
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
16 if (params[19] < 0 || params[19] > 1) /* UFI */ |
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 return -1; |
514
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
18 if (params[20] < 0 || params[20] > 2) /* SID */ |
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
19 return -1; |
67b13a6a63c9
libgsmhr1: implement validation for *.dec frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
513
diff
changeset
|
20 if (params[21] < 0 || params[21] > 1) /* TAF */ |
513
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 return -1; |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 return gsmhr_check_common_params(params); |
03a40ac2e931
libgsmhr1: implement validation for *.cod frames
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
23 } |