comparison libtwamr/enc_main.c @ 477:4c9222d95647

libtwamr encoder: always emit frame->mode = mode; In the original implementation of amr_encode_frame(), the 'mode' member of the output struct was set to 0xFF if the output frame type is TX_NO_DATA. This design was made to mimic the mode field (16-bit word) being set to 0xFFFF (or -1) in 3GPP test sequence format - but nothing actually depends on this struct member being set in any way, and amr_frame_to_tseq() generates the needed 0xFFFF on its own, based on frame->type being equal to TX_NO_DATA. It is simpler and more efficient to always set frame->mode to the actual encoding mode in amr_encode_frame(), and this new behavior has already been documented in doc/AMR-library-API description in anticipation of the present change.
author Mychaela Falconia <falcon@freecalypso.org>
date Sat, 18 May 2024 22:30:42 +0000
parents 2a094af3d384
children
comparison
equal deleted inserted replaced
476:c84bf526c7eb 477:4c9222d95647
51 51
52 /* main process */ 52 /* main process */
53 cod_amr(&st->cod, mode, new_speech, frame->param, &used_mode, syn); 53 cod_amr(&st->cod, mode, new_speech, frame->param, &used_mode, syn);
54 sid_sync(&st->sid, used_mode, &tx_type); 54 sid_sync(&st->sid, used_mode, &tx_type);
55 frame->type = tx_type; 55 frame->type = tx_type;
56 if (tx_type != TX_NO_DATA) 56 frame->mode = mode;
57 frame->mode = mode;
58 else
59 frame->mode = 0xFF;
60 57
61 /* encoder homing */ 58 /* encoder homing */
62 if (encoder_homing_frame_test(pcm)) 59 if (encoder_homing_frame_test(pcm))
63 amr_encoder_reset(st, st->cod.dtx, st->cod.vadSt.use_vad2); 60 amr_encoder_reset(st, st->cod.dtx, st->cod.vadSt.use_vad2);
64 } 61 }