FreeCalypso > hg > gsm-codec-lib
comparison libgsmfrp/internal.h @ 242:f081a6850fb5
libgsmfrp: new refined implementation
The previous implementation exhibited the following defects,
which are now fixed:
1) The last received valid SID was cached forever for the purpose of
handling future invalid SIDs - we could have received some valid
SID ages ago, then lots of speech or NO_DATA, and if we then get
an invalid SID, we would resurrect the last valid SID from ancient
history - a bad design. In our new design, we handle invalid SID
based on the current state, much like BFI.
2) GSM 06.11 spec says clearly that after the second lost SID
(received BFI=1 && TAF=1 in CN state) we need to gradually decrease
the output level, rather than jump directly to emitting silence
frames - we previously failed to implement such logic.
3) Per GSM 06.12 section 5.2, Xmaxc should be the same in all 4 subframes
in a SID frame. What should we do if we receive an otherwise valid
SID frame with different Xmaxc? Our previous approach would
replicate this Xmaxc oddity in every subsequent generated CN frame,
which is rather bad. In our new design, the very first CN frame
(which can be seen as a transformation of the SID frame itself)
retains the original 4 distinct Xmaxc, but all subsequent CN frames
are based on the Xmaxc from the last subframe of the most recent SID.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 09 May 2023 05:16:31 +0000 |
parents | 3b64f255689a |
children | 6ac547f0b903 |
comparison
equal
deleted
inserted
replaced
241:a48ddaa0f9a7 | 242:f081a6850fb5 |
---|---|
7 NO_DATA = 0, | 7 NO_DATA = 0, |
8 SPEECH, | 8 SPEECH, |
9 SPEECH_MUTING, | 9 SPEECH_MUTING, |
10 COMFORT_NOISE, | 10 COMFORT_NOISE, |
11 LOST_SID, | 11 LOST_SID, |
12 CN_MUTING, | |
12 }; | 13 }; |
13 | 14 |
14 struct gsmfr_preproc_state { | 15 struct gsmfr_preproc_state { |
15 enum rx_state rx_state; | 16 enum rx_state rx_state; |
16 int got_valid_sid; | |
17 gsm_frame speech_frame; | 17 gsm_frame speech_frame; |
18 gsm_byte sid_prefix[5]; | 18 gsm_byte sid_prefix[5]; |
19 uint8_t sid_xmaxc[4]; | 19 uint8_t sid_xmaxc; |
20 uint32_t cn_random_lfsr; | 20 uint32_t cn_random_lfsr; |
21 unsigned cn_random_6fold; | 21 unsigned cn_random_6fold; |
22 }; | 22 }; |
23 | 23 |
24 /* we use the same LFSR PRNG for CN as ETSI EFR implementation */ | 24 /* we use the same LFSR PRNG for CN as ETSI EFR implementation */ |
25 #define PN_INITIAL_SEED 0x70816958L /* Pseudo noise generator seed value */ | 25 #define PN_INITIAL_SEED 0x70816958L /* Pseudo noise generator seed value */ |
26 | 26 |
27 /* internal functions */ | 27 /* internal functions */ |
28 extern void gsmfr_preproc_gen_cn(struct gsmfr_preproc_state *state, | 28 extern void gsmfr_preproc_gen_cn(struct gsmfr_preproc_state *state, |
29 gsm_byte *frame); | 29 gsm_byte *frame); |
30 extern void gsmfr_preproc_sid2cn(struct gsmfr_preproc_state *state, | |
31 gsm_byte *frame); | |
32 extern void gsmfr_preproc_invalid_sid(struct gsmfr_preproc_state *state, | |
33 gsm_byte *frame); | |
30 extern uint16_t gsmfr_preproc_prng(struct gsmfr_preproc_state *state, | 34 extern uint16_t gsmfr_preproc_prng(struct gsmfr_preproc_state *state, |
31 uint16_t no_bits); | 35 uint16_t no_bits); |