FreeCalypso > hg > gsm-codec-lib
diff libtest/tw5reader.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Tue, 25 Feb 2025 07:49:28 +0000 |
| parents | 4d2cccaeb4a7 |
| children |
line wrap: on
line diff
--- a/libtest/tw5reader.c Fri Feb 14 01:34:48 2025 +0000 +++ b/libtest/tw5reader.c Tue Feb 25 07:49:28 2025 +0000 @@ -22,7 +22,7 @@ int twts005_read_frame(FILE *hexf, unsigned *lineno, uint8_t *frame, unsigned *lenp) { - char linebuf[81]; + char linebuf[82]; char *cp, *np; uint8_t *dp; unsigned len;