FreeCalypso > hg > gsm-codec-lib
view libgsmefr/tls_flags.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | 38326102fc43 |
children |
line wrap: on
line source
/* * Unfortunately the code we got from ETSI makes heavy use of two global * Boolean flags named Carry and Overflow that function like equally named * processor state flags on many CPU architectures. They are not part * of persistent codec session state for either the encoder or the decoder, * instead they are "short-term" globals much like UNIX errno. * * Given this unfortunate reality plus the natural desire to make our * EFR library thread-safe (a transcoding MGW handling a large volume of * simultaneous calls is exactly the kind of application that would benefit * from utilitizing all CPU cores), our current workaround is to use * thread-local storage. */ #include <stdint.h> #include "typedef.h" __thread Flag EFR__Carry, EFR__Overflow;