FreeCalypso > hg > gsm-codec-lib
view libtwamr/ietf_out.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | ebe499058c63 |
children |
line wrap: on
line source
/* * The function implemented in this module is responsible for turning * struct amr_param_frame (encoder output) into an RFC 4867 payload. */ #include <stdint.h> #include "tw_amr.h" #include "typedef.h" #include "namespace.h" #include "cnst.h" #include "int_defs.h" #include "if1_func.h" static const uint8_t total_bytes_per_ft[9] = {13, 14, 16, 18, 20, 21, 27, 32, 6}; static const uint8_t first_octet_per_ft[9] = {0x04, 0x0C, 0x14, 0x1C, 0x24, 0x2C, 0x34, 0x3C, 0x44}; unsigned amr_frame_to_ietf(const struct amr_param_frame *frame, uint8_t *bytes) { Word16 serial[MAX_SERIAL_SIZE]; Word16 sti; enum Mode ft; switch (frame->type) { case TX_SPEECH_GOOD: ft = frame->mode; break; case TX_SID_FIRST: ft = MRDTX; sti = 0; break; case TX_SID_UPDATE: ft = MRDTX; sti = 1; break; case TX_NO_DATA: default: bytes[0] = 0x7C; return 1; } Prm2bits(ft, frame->param, serial); bytes[0] = first_octet_per_ft[ft]; if1_pack_bytes(ft, serial, bytes + 1); if (ft == MRDTX) { if (sti) bytes[5] |= 0x10; if (frame->mode & 1) bytes[5] |= 0x08; if (frame->mode & 2) bytes[5] |= 0x04; if (frame->mode & 4) bytes[5] |= 0x02; } return total_bytes_per_ft[ft]; }