FreeCalypso > hg > gsm-codec-lib
view doc/EFR-testing @ 477:4c9222d95647
libtwamr encoder: always emit frame->mode = mode;
In the original implementation of amr_encode_frame(), the 'mode' member
of the output struct was set to 0xFF if the output frame type is TX_NO_DATA.
This design was made to mimic the mode field (16-bit word) being set to
0xFFFF (or -1) in 3GPP test sequence format - but nothing actually depends
on this struct member being set in any way, and amr_frame_to_tseq()
generates the needed 0xFFFF on its own, based on frame->type being equal
to TX_NO_DATA.
It is simpler and more efficient to always set frame->mode to the actual
encoding mode in amr_encode_frame(), and this new behavior has already
been documented in doc/AMR-library-API description in anticipation of
the present change.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sat, 18 May 2024 22:30:42 +0000 |
| parents | 1e8569000049 |
| children |
line wrap: on
line source
When it comes to codec libraries, testing for correctness is essential, and EFR is no exception. There is a set of EFR encoder and decoder test sequences published by ETSI in ts_100725v050200p0.zip (GSM 06.54), and our suite of tools includes gsmefr-etsi-enc and gsmefr-etsi-dec test programs that operate on the representation formats used by these test sequences. Because these test programs are based on libgsmefr EFR_encode_frame() and EFR_decode_frame() functions, seeing gsmefr-etsi-enc produce output that matches official ETSI *.cod files proves that libgsmefr encoder is correct, and seeing gsmefr-etsi-dec produce output that matches official ETSI *.out files proves that libgsmefr decoder is correct. For debugging, we also have gsmefr-cod-parse and gsmefr-dec-parse utilities that parse ETSI *.cod and *.dec file formats and dump their content in human-readable form similar to gsmrec-dump. Please note that all ETSI test sequence file formats are endian-dependent: their original programs read and write 16-bit words in the local machine's native byte order, and whenever you are working with published test sequence files, you have to check to see if they are BE or LE. Our gsmefr-etsi-{enc,dec} and gsmefr-{cod,dec}-parse programs support both byte orders; the default is LE (matching the main parts of ts_100725v050200p0.zip), or you can select BE with -b option.