FreeCalypso > hg > gsm-codec-lib
view libgsmefr/tls_flags.c @ 477:4c9222d95647
libtwamr encoder: always emit frame->mode = mode;
In the original implementation of amr_encode_frame(), the 'mode' member
of the output struct was set to 0xFF if the output frame type is TX_NO_DATA.
This design was made to mimic the mode field (16-bit word) being set to
0xFFFF (or -1) in 3GPP test sequence format - but nothing actually depends
on this struct member being set in any way, and amr_frame_to_tseq()
generates the needed 0xFFFF on its own, based on frame->type being equal
to TX_NO_DATA.
It is simpler and more efficient to always set frame->mode to the actual
encoding mode in amr_encode_frame(), and this new behavior has already
been documented in doc/AMR-library-API description in anticipation of
the present change.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Sat, 18 May 2024 22:30:42 +0000 |
parents | 38326102fc43 |
children |
line wrap: on
line source
/* * Unfortunately the code we got from ETSI makes heavy use of two global * Boolean flags named Carry and Overflow that function like equally named * processor state flags on many CPU architectures. They are not part * of persistent codec session state for either the encoder or the decoder, * instead they are "short-term" globals much like UNIX errno. * * Given this unfortunate reality plus the natural desire to make our * EFR library thread-safe (a transcoding MGW handling a large volume of * simultaneous calls is exactly the kind of application that would benefit * from utilitizing all CPU cores), our current workaround is to use * thread-local storage. */ #include <stdint.h> #include "typedef.h" __thread Flag EFR__Carry, EFR__Overflow;