FreeCalypso > hg > gsm-codec-lib
view Makefile @ 581:e2d5cad04cbf
libgsmhr1 RxFE: store CN R0+LPC separately from speech
In the original GSM 06.06 code the ECU for speech mode is entirely
separate from the CN generator, maintaining separate state. (The
main intertie between them is the speech vs CN state variable,
distinguishing between speech and CN BFIs, in addition to the
CN-specific function of distinguishing between initial and update
SIDs.)
In the present RxFE implementation I initially thought that we could
use the same saved_frame buffer for both ECU and CN, overwriting
just the first 4 params (R0 and LPC) when a valid SID comes in.
However, I now realize it was a bad idea: the original code has a
corner case (long sequence of speech-mode BFIs to put the ECU in
state 6, then SID and CN-mode BFIs, then a good speech frame) that
would be broken by that buffer reuse approach. We could eliminate
this corner case by resetting the ECU state when passing through
a CN insertion period, but doing so would needlessly increase
the behavioral diffs between GSM 06.06 and our version.
Solution: use a separate CN-specific buffer for CN R0+LPC parameters,
and match the behavior of GSM 06.06 code in this regard.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 13 Feb 2025 10:02:45 +0000 |
| parents | a81ce3cd38a7 |
| children |
line wrap: on
line source
SUBDIR_LIBPROD= libgsmefr libgsmfr2 libgsmhr1 libtwamr SUBDIR_UTILS= amrconv amrefr amrtest efrtest frtest hrutil miscutil SUBDIR_INT= dev libtest SUBDIR= ${SUBDIR_LIBPROD} ${SUBDIR_UTILS} ${SUBDIR_INT} SUBDIR_INST= ${SUBDIR_LIBPROD} ${SUBDIR_UTILS} DESTDIR= all: ${SUBDIR} amrconv: libtest amrefr: libgsmefr libtest libtwamr amrtest: libtest libtwamr efrtest: libgsmefr libtest frtest: libgsmfr2 libtest hrutil: libgsmhr1 libtest miscutil: libgsmefr libgsmfr2 libtest ${SUBDIR}: FRC config.defs cd $@; ${MAKE} ${MFLAGS} config.defs: @echo 'You must run ./configure before make' @false install: FRC for i in ${SUBDIR_INST}; do (cd $$i; ${MAKE} ${MFLAGS} \ DESTDIR=${DESTDIR} install); done # The following two subset install targets are only for experts; # if you are not sure why they are needed, you *don't* need them! install-lib: FRC for i in ${SUBDIR_LIBPROD}; do (cd $$i; ${MAKE} ${MFLAGS} \ DESTDIR=${DESTDIR} install); done install-utils: FRC for i in ${SUBDIR_UTILS}; do (cd $$i; ${MAKE} ${MFLAGS} \ DESTDIR=${DESTDIR} install); done clean: FRC rm -f a.out core errs for i in ${SUBDIR}; do (cd $$i; ${MAKE} ${MFLAGS} clean); done FRC: