FreeCalypso > hg > gsm-codec-lib
view libgsmhr1/rxfe.h @ 581:e2d5cad04cbf
libgsmhr1 RxFE: store CN R0+LPC separately from speech
In the original GSM 06.06 code the ECU for speech mode is entirely
separate from the CN generator, maintaining separate state. (The
main intertie between them is the speech vs CN state variable,
distinguishing between speech and CN BFIs, in addition to the
CN-specific function of distinguishing between initial and update
SIDs.)
In the present RxFE implementation I initially thought that we could
use the same saved_frame buffer for both ECU and CN, overwriting
just the first 4 params (R0 and LPC) when a valid SID comes in.
However, I now realize it was a bad idea: the original code has a
corner case (long sequence of speech-mode BFIs to put the ECU in
state 6, then SID and CN-mode BFIs, then a good speech frame) that
would be broken by that buffer reuse approach. We could eliminate
this corner case by resetting the ECU state when passing through
a CN insertion period, but doing so would needlessly increase
the behavioral diffs between GSM 06.06 and our version.
Solution: use a separate CN-specific buffer for CN R0+LPC parameters,
and match the behavior of GSM 06.06 code in this regard.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Thu, 13 Feb 2025 10:02:45 +0000 |
parents | 1dc5d9320e96 |
children |
line wrap: on
line source
/* * This library-internal header file provides definition for * struct gsmhr_rxfe_state, the state structure for our Rx front end * that can function either as part of the full endpoint decoder * or standalone as a TFO transform. The internal interface function * to the RxFE block as a whole (to be called from the full decoder * or from the TFO wrapper) is also declared here. */ #ifndef rxfe_h #define rxfe_h #include <stdint.h> #include "tw_gsmhr.h" #include "typedefs.h" #define GS_HISTORY_SIZE 28 struct gsmhr_rxfe_state { Shortword saved_frame[GSMHR_NUM_PARAMS]; Longword gs_history[GS_HISTORY_SIZE]; Shortword cn_r0_lpc[4]; Longword cn_prng; Shortword gs_cn_out; uint8_t in_dtx; uint8_t ecu_state; uint8_t dtx_bfi_count; uint8_t dtx_muting; uint8_t gs_history_ptr; }; void rxfe_main(struct gsmhr_rxfe_state *st, const Shortword *prm_in, Shortword *prm_out, int fast_cn_muting, Shortword *deco_mode_out, Shortword *mute_permit, Shortword *dtxd_sp); #endif /* include guard */