FreeCalypso > hg > gsm-codec-lib
view frtest/decode-r.c @ 585:3c6bf0d26ee7 default tip
TW-TS-005 reader: fix maximum line length bug
TW-TS-005 section 4.1 states:
The maximum allowed length of each line is 80 characters, not
including the OS-specific newline encoding.
The implementation of this line length limit in the TW-TS-005 hex file
reader function in the present suite was wrong, such that lines of
the full maximum length could not be read. Fix it.
Note that this bug affects comment lines too, not just actual RTP
payloads. Neither Annex A nor Annex B features an RTP payload format
that goes to the maximum of 40 bytes, but if a comment line goes to
the maximum allowed length of 80 characters not including the
terminating newline, the bug will be triggered, necessitating
the present fix.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Tue, 25 Feb 2025 07:49:28 +0000 |
parents | cfa3006a66da |
children |
line wrap: on
line source
/* * gsmfr-decode-r is like gsmfr-decode, but writes the decoded PCM * output in our "robe" format instead of WAV. */ #include <stdio.h> #include <stdint.h> #include <stdlib.h> #include "../libgsmfr2/tw_gsmfr.h" #include "../libtest/binreader.h" #include "../libtest/robewrite.h" main(argc, argv) char **argv; { FILE *binf, *outf; struct gsmfr_fulldec_state *fd_state; uint8_t frame[BINFILE_MAX_FRAME]; int16_t pcm[160]; int rc, bfi, taf; if (argc != 3) { fprintf(stderr, "usage: %s input.gsm output.robe\n", argv[0]); exit(1); } binf = fopen(argv[1], "r"); if (!binf) { perror(argv[1]); exit(1); } outf = fopen(argv[2], "w"); if (!outf) { perror(argv[2]); exit(1); } fd_state = gsmfr_fulldec_create(); if (!fd_state) { fprintf(stderr, "gsmfr_fulldec_create() failed!\n"); exit(1); } for (;;) { rc = binfile_read_frame(binf, frame); if (rc < 0) { fprintf(stderr, "error: garbage in %s\n", argv[1]); exit(1); } if (!rc) break; if (frame[0] == 0xBF) { bfi = 1; taf = frame[1] & 1; } else if ((frame[0] & 0xF0) == 0xD0) bfi = 0; else { fprintf(stderr, "error: %s is not in FR codec format\n", argv[1]); exit(1); } if (bfi) gsmfr_fulldec_bfi(fd_state, taf, pcm); else gsmfr_fulldec_good_frame(fd_state, frame, pcm); write_pcm_to_robe(outf, pcm); } fclose(outf); exit(0); }