# HG changeset patch # User Mychaela Falconia # Date 1670731213 0 # Node ID a5ffec18e4cd349ef6c34f1a6920cf93aea95b71 # Parent 4af99bf8671a0964aea7a081853f5278106cfb9c test programs: use printf %d format for codec parameters Even though all codec params (both FR and EFR) are small unsigned integers, we use signed int16_t data type for both, for interface reasons: in the case of FR it's the gsm_signal type of libgsm, and in the case of EFR it's the Word16 type of ETSI codec guts. Therefore, the correct printf format is %d, not %u, when the objective is to see what's in the variables (what the compiler sees) and catch any bugs. diff -r 4af99bf8671a -r a5ffec18e4cd efrtest/cod-parse.c --- a/efrtest/cod-parse.c Sun Dec 11 03:25:21 2022 +0000 +++ b/efrtest/cod-parse.c Sun Dec 11 04:00:13 2022 +0000 @@ -108,12 +108,12 @@ EFR_frame2params(frame, params); n = 0; for (i = 0; i < 5; i++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); for (i = 0; i < 4; i++) { putchar(' '); for (j = 0; j < 13; j++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); } } diff -r 4af99bf8671a -r a5ffec18e4cd frtest/max-out.c --- a/frtest/max-out.c Sun Dec 11 03:25:21 2022 +0000 +++ b/frtest/max-out.c Sun Dec 11 04:00:13 2022 +0000 @@ -75,12 +75,12 @@ gsm_explode(dec_state, frame, fr_params); n = 0; for (i = 0; i < 8; i++) - printf(" %u", fr_params[n++]); + printf(" %d", fr_params[n++]); putchar('\n'); for (i = 0; i < 4; i++) { putchar(' '); for (j = 0; j < 17; j++) - printf(" %u", fr_params[n++]); + printf(" %d", fr_params[n++]); putchar('\n'); } break; @@ -97,12 +97,12 @@ gsm_explode(dec_state, frame, fr_params); n = 0; for (i = 0; i < 8; i++) - printf(" %u", fr_params[n++]); + printf(" %d", fr_params[n++]); putchar('\n'); for (i = 0; i < 4; i++) { putchar(' '); for (j = 0; j < 17; j++) - printf(" %u", fr_params[n++]); + printf(" %d", fr_params[n++]); putchar('\n'); } gsm_decode(dec_state, frame, pcm); diff -r 4af99bf8671a -r a5ffec18e4cd miscutil/gsmrec-dump.c --- a/miscutil/gsmrec-dump.c Sun Dec 11 03:25:21 2022 +0000 +++ b/miscutil/gsmrec-dump.c Sun Dec 11 04:00:13 2022 +0000 @@ -52,12 +52,12 @@ EFR_frame2params(frame, params); n = 0; for (i = 0; i < 5; i++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); for (i = 0; i < 4; i++) { putchar(' '); for (j = 0; j < 13; j++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); } break; @@ -66,12 +66,12 @@ gsm_explode(dummy_state, frame, params); n = 0; for (i = 0; i < 8; i++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); for (i = 0; i < 4; i++) { putchar(' '); for (j = 0; j < 17; j++) - printf(" %u", params[n++]); + printf(" %d", params[n++]); putchar('\n'); } break;