comparison efr-sid/Unit-test-desc @ 54:0832b5ac62b2

efr-sid/Unit-test-desc: update for complete status
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 19 Aug 2024 17:40:43 +0000
parents 637ee027999b
children
comparison
equal deleted inserted replaced
53:637ee027999b 54:0832b5ac62b2
23 The official reference (source of truth) is GSM 06.62 spec for the definition 23 The official reference (source of truth) is GSM 06.62 spec for the definition
24 of SID field bits and GSM 06.81 spec for SID classification thresholds; all 24 of SID field bits and GSM 06.81 spec for SID classification thresholds; all
25 implementations listed above are supposed to follow these spec definitions. 25 implementations listed above are supposed to follow these spec definitions.
26 However, any time a human developer has to read a spec and write code based on 26 However, any time a human developer has to read a spec and write code based on
27 that spec, errors can occur at any step in that process; a cross-check between 27 that spec, errors can occur at any step in that process; a cross-check between
28 our implementation and those made by others before us will provide an important 28 our implementation and those made by others before us provides an important
29 assurance of correctness. 29 assurance of correctness.
30 30
31 The test frames generated here have been chosen with the goal of maximizing 31 The test frames generated here have been chosen with the goal of maximizing
32 the chance of catching errors in these two areas: 32 the chance of catching errors in these two areas:
33 33
34 * Wrong bits being set by tools aiming to generate or corrupt the SID field, 34 * Wrong bits being set by tools aiming to generate or corrupt the SID field,
35 or wrong bits being checked by the SID detector; 35 or wrong bits being checked by the SID detector;
36 * Wrong thresholds being applied for SID classification. 36 * Wrong thresholds being applied for SID classification.
37 37
38 The generator program in this directory and Themyscira libgsmefr are already 38 The generator program in this directory and Themyscira libgsmefr were already
39 in agreement; once we test on TI Calypso DSP and on Nokia InSite, we will have 39 in agreement since the beginning of this test data project. The test sequence
40 full confidence in the correctness of our implementation. The same test data 40 generated in this directory has now been tested on TI Calypso DSP (fed via TCH
41 will then be added to libosmocore as a regression test. 41 DL) and on Nokia InSite BTS (fed via TCH UL); both of these pre-existing
42 historical implementations of TCH Rx produce SID classifications that are
43 identical to our expectations. The present set of test patterns has also been
44 added as a unit test to libosmocore, regression-testing osmo_efr_sid_classify()
45 function.