# HG changeset patch # User Mychaela Falconia # Date 1724089243 0 # Node ID 0832b5ac62b28242e2c902e746564bcde05c80f5 # Parent 637ee027999b078d3dea8a5a7532d262e76d53db efr-sid/Unit-test-desc: update for complete status diff -r 637ee027999b -r 0832b5ac62b2 efr-sid/Unit-test-desc --- a/efr-sid/Unit-test-desc Mon Aug 12 03:39:42 2024 +0000 +++ b/efr-sid/Unit-test-desc Mon Aug 19 17:40:43 2024 +0000 @@ -25,7 +25,7 @@ implementations listed above are supposed to follow these spec definitions. However, any time a human developer has to read a spec and write code based on that spec, errors can occur at any step in that process; a cross-check between -our implementation and those made by others before us will provide an important +our implementation and those made by others before us provides an important assurance of correctness. The test frames generated here have been chosen with the goal of maximizing @@ -35,7 +35,11 @@ or wrong bits being checked by the SID detector; * Wrong thresholds being applied for SID classification. -The generator program in this directory and Themyscira libgsmefr are already -in agreement; once we test on TI Calypso DSP and on Nokia InSite, we will have -full confidence in the correctness of our implementation. The same test data -will then be added to libosmocore as a regression test. +The generator program in this directory and Themyscira libgsmefr were already +in agreement since the beginning of this test data project. The test sequence +generated in this directory has now been tested on TI Calypso DSP (fed via TCH +DL) and on Nokia InSite BTS (fed via TCH UL); both of these pre-existing +historical implementations of TCH Rx produce SID classifications that are +identical to our expectations. The present set of test patterns has also been +added as a unit test to libosmocore, regression-testing osmo_efr_sid_classify() +function.