annotate LICENSE @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 27b356aa0e5d
children 3e5689c0ca4e
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
229
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 Notice of Adoption
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 ==================
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 I, Mychaela Nadezhda Falconia, hereby appoint myself as the Adoptive Mother of
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 the GSM mobile station firmware code that has been abandoned, disowned and
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 discarded in the trash by Texas Instruments (TI). I argue that by effectively
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 disowning this code and discarding it in the trash, TI have forfeited any and
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 all rights they may have had to this code, both moral and economic, and I ask
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 the users and distributors of my code to ignore and disregard any and all TI
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 copyright notices interspersed in various individual source files.
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 Declaration of Free Software Status
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 ===================================
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 I, Mychaela Nadezhda Falconia, the Adoptive Mother of the software contained in
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 this source repository, develop, maintain and distribute this work with the
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 intention that it be treated as Free Software. Specifically:
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 * By virtue of there being no one to stop you from doing so, you may use this
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 code as you wish, for any purpose whatsoever;
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 * By virtue of the complete source code being published, you may study how this
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 code works, and change it so it does whatever you desire;
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 * By virtue of there being no one to stop you from doing so, you may
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 redistribute copies of this code however you like;
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 * Also by virtue of there being no one to stop you from doing so, you may
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 distribute modified versions to others as well.
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 Because the present developer, maintainer and distributor of this code is me
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 and not TI, I argue that my granting of all of the above freedoms to the user
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 community should supercede the lack of such grant from TI, and that my work has
27b356aa0e5d LICENSE explanatory file added
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34 the right to be treated as Free Software.