FreeCalypso > hg > fc-magnetite
view LICENSE @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 27b356aa0e5d |
| children | 3e5689c0ca4e |
line wrap: on
line source
Notice of Adoption ================== I, Mychaela Nadezhda Falconia, hereby appoint myself as the Adoptive Mother of the GSM mobile station firmware code that has been abandoned, disowned and discarded in the trash by Texas Instruments (TI). I argue that by effectively disowning this code and discarding it in the trash, TI have forfeited any and all rights they may have had to this code, both moral and economic, and I ask the users and distributors of my code to ignore and disregard any and all TI copyright notices interspersed in various individual source files. Declaration of Free Software Status =================================== I, Mychaela Nadezhda Falconia, the Adoptive Mother of the software contained in this source repository, develop, maintain and distribute this work with the intention that it be treated as Free Software. Specifically: * By virtue of there being no one to stop you from doing so, you may use this code as you wish, for any purpose whatsoever; * By virtue of the complete source code being published, you may study how this code works, and change it so it does whatever you desire; * By virtue of there being no one to stop you from doing so, you may redistribute copies of this code however you like; * Also by virtue of there being no one to stop you from doing so, you may distribute modified versions to others as well. Because the present developer, maintainer and distributor of this code is me and not TI, I argue that my granting of all of the above freedoms to the user community should supercede the lack of such grant from TI, and that my work has the right to be treated as Free Software.